Issue 687233002: Revert of Discard atlas after every MultiPictureDraw::draw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687233002: Revert of Discard atlas after every MultiPictureDraw::draw (Closed)

Created:
6 years, 1 month ago by robertphillips

Modified:
6 years, 1 month ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Discard atlas after every MultiPictureDraw::draw (patchset #4 id:60001 of https://codereview.chromium.org/678403002/) Reason for revert: Breaking bots Original issue's description: > Discard atlas after every MultiPictureDraw::draw > > This is intended to prevent ghosting on tiled architectures. > > This CL also defers creation of the atlas (and its texture) until it is actually needed. > > Committed: https://skia.googlesource.com/skia/+/6d5b5455743414ddb11d2b8c1fe9d7959f2b853d TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9f36b8719b5fab2e3d7f25c5299438f954d06052

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -51 lines)			Patch
M	src/core/SkMultiPictureDraw.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/GrLayerCache.h	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	src/gpu/GrLayerCache.cpp	View	9 chunks	+14 lines, -27 lines	0 comments	Download
M	src/gpu/GrLayerHoister.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/gpu/GrLayerHoister.cpp	View	1 chunk	+5 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Discard atlas after every MultiPictureDraw::draw

6 years, 1 month ago (2014-10-29 15:16:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687233002/1

6 years, 1 month ago (2014-10-29 15:17:25 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-29 15:17:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 9f36b8719b5fab2e3d7f25c5299438f954d06052