chrome/browser/resources/extensions/extension_list.js - Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_305800

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/about_memory.js ('k') | chrome/browser/resources/help/help_base_page.js » ('j') | chrome/browser/resources/help/help_base_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index 7d6187ae2b76e2f41357402194d01065490b3563..47ce78b707ec1ab09932167573b1a6e1a0b7eef2 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -59,8 +59,10 @@ cr.define('options', function() {

// the way at the top. That way it is clear that there are more elements

// above the element being scrolled to.

var scrollFudge = 1.2;

- document.documentElement.scrollTop = $(idToHighlight).offsetTop -

- scrollFudge * $(idToHighlight).clientHeight;

+ var scrollTop =

+ $(idToHighlight).offsetTop - scrollFudge *

+ $(idToHighlight).clientHeight;

Dan Beam 2013/11/13 23:31:07 nit: var scrollTop = $(idToHighlight).offsetTop -

+ setScrollTopForDocument(document, scrollTop);

}

if (this.data_.extensions.length == 0)

@@ -336,7 +338,7 @@ cr.define('options', function() {

var pad = parseInt(getComputedStyle(node, null).marginTop, 10);

if (!isNaN(pad))

topScroll -= pad / 2;

- document.documentElement.scrollTop = topScroll;

+ setScrollTopForDocument(document, topScroll);

}

};