chrome/browser/resources/uber/uber_utils.js - Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/uber/uber_utils.js

Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_305800

Patch Set: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/uber/uber_utils.js

diff --git a/chrome/browser/resources/uber/uber_utils.js b/chrome/browser/resources/uber/uber_utils.js

index 04f8ba1fe9391efab9a9cd882973ee51c93d491e..5f5c6d2a28af31465f8b9379ddb6dbe89a0a3806 100644

--- a/chrome/browser/resources/uber/uber_utils.js

+++ b/chrome/browser/resources/uber/uber_utils.js

@@ -39,7 +39,8 @@ cr.define('uber', function() {

* @private

function handleScroll() {

- var offset = document.documentElement.scrollLeft * -1;

+ var scrollLeft = scrollLeftForDocument(document);

+ var offset = scrollLeft * -1;

for (var i = 0; i < headerElements.length; i++) {

// As a workaround for http://crbug.com/231830, set the transform to

// 'none' rather than 0px.

@@ -47,7 +48,7 @@ cr.define('uber', function() {

'translateX(' + offset + 'px)' : 'none';

}

- invokeMethodOnParent('adjustToScroll', document.documentElement.scrollLeft);

+ invokeMethodOnParent('adjustToScroll', scrollLeft);

};

/**

@@ -67,7 +68,7 @@ cr.define('uber', function() {

* @private

function handleFrameSelected() {

- document.documentElement.scrollLeft = 0;

+ setScrollTopForDocument(document, 0);

}

/**

« no previous file with comments | « chrome/browser/resources/options/options_page.js ('k') | ui/webui/resources/js/util.js » ('j') | ui/webui/resources/js/util.js » ('J')