chrome/browser/resources/help/help_base_page.js - Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/help/help_base_page.js

Issue 68723003: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_305800

Patch Set: Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extension_list.js ('k') | chrome/browser/resources/ntp_android/ntp_android.js » ('j') | ui/webui/resources/js/util.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/help/help_base_page.js

diff --git a/chrome/browser/resources/help/help_base_page.js b/chrome/browser/resources/help/help_base_page.js

index f07a9f1e0cd58df9eaf3c7ef0ce582f47325e0cf..52d30591bd989fbcf34b1101dc8cb9d5c2bd23a9 100644

--- a/chrome/browser/resources/help/help_base_page.js

+++ b/chrome/browser/resources/help/help_base_page.js

@@ -115,13 +115,16 @@ cr.define('help', function() {

* @private

freeze_: function(freeze) {

+ var scrollTop = scrollTopForDocument(document);

+ var scrollLeft = scrollLeftForDocument(document);

if (freeze) {

- this.lastScrollTop = document.documentElement.scrollTop;

+ this.lastScrollTop = scrollTop;

document.body.style.overflow = 'hidden';

- window.scroll(document.documentElement.scrollLeft, 0);

+ window.scroll(scrollLeft, 0);

} else {

document.body.style.overflow = 'auto';

- window.scroll(document.documentElement.scrollLeft, this.lastScrollTop);

+ window.scroll(scrollLeft, this.lastScrollTop);

}