Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left

chrome/browser/resources/options/options_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var FocusOutlineManager = cr.ui.FocusOutlineManager;
 
   /////////////////////////////////////////////////////////////////////////////
   // OptionsPage class:
 
@@ skipping 186 matching lines @@
 
   /**
    * Scrolls the page to the correct position (the top when opening an overlay,
    * or the old scroll position a previously hidden overlay becomes visible).
    * @private
    */
   OptionsPage.updateScrollPosition_ = function() {
     var container = $('page-container');
     var scrollTop = container.oldScrollTop || 0;
     container.oldScrollTop = undefined;
-    window.scroll(document.documentElement.scrollLeft, scrollTop);
+    var scrollLeft = scrollLeftForDocument(document);
+    window.scroll(scrollLeft, scrollTop);

[Dan Beam, 2013/11/13 23:31:07]

nit: window.scroll(scrollLeftForDocument(document), scrollTop);

   };
 
   /**
    * Pushes the current page onto the history stack, overriding the last page
    * if it is the generic chrome://settings/.
    * @param {boolean} replace If true, allow no history events to be created.
    * @param {object=} opt_params A bag of optional params, including:
    *     {boolean} ignoreHash Whether to include the hash or not.
    * @private
    */
@@ skipping 386 matching lines @@
    * @private
    */
   OptionsPage.setRootPageFrozen_ = function(freeze) {
     var container = $('page-container');
     if (container.classList.contains('frozen') == freeze)
       return;
 
     if (freeze) {
       // Lock the width, since auto width computation may change.
       container.style.width = window.getComputedStyle(container).width;
-      container.oldScrollTop = document.documentElement.scrollTop;
+      container.oldScrollTop = scrollTopForDocument(document);
       container.classList.add('frozen');
       var verticalPosition =
           container.getBoundingClientRect().top - container.oldScrollTop;
       container.style.top = verticalPosition + 'px';
       this.updateFrozenElementHorizontalPosition_(container);
     } else {
       container.classList.remove('frozen');
       container.style.top = '';
       container.style.left = '';
       container.style.right = '';
@@ skipping 71 matching lines @@
 
   /**
    * Updates the given frozen element to match the horizontal scroll position.
    * @param {HTMLElement} e The frozen element to update.
    * @private
    */
   OptionsPage.updateFrozenElementHorizontalPosition_ = function(e) {
     if (isRTL()) {
       e.style.right = OptionsPage.horizontalOffset + 'px';
     } else {
-      e.style.left = OptionsPage.horizontalOffset -
-          document.documentElement.scrollLeft + 'px';
+      var scrollLeft = scrollLeftForDocument(document);
+      e.style.left = OptionsPage.horizontalOffset - scrollLeft + 'px';
     }
   };
 
   /**
    * Change the horizontal offset used to reposition elements while showing an
    * overlay from the default.
    */
   OptionsPage.setHorizontalOffset = function(value) {
     OptionsPage.horizontalOffset = value;
   };
@@ skipping 279 matching lines @@
     canShowPage: function() {
       return true;
     },
   };
 
   // Export
   return {
     OptionsPage: OptionsPage
   };
 });