Make chrome/ be documentElement/body agnostic with regards to scrollTop/Left

ui/webui/resources/js/util.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="assert.js">
 
 /**
  * The global object.
  * @type {!Object}
  * @const
@@ skipping 303 matching lines @@
   var fired = false;
   el.addEventListener('webkitTransitionEnd', function f(e) {
     el.removeEventListener('webkitTransitionEnd', f);
     fired = true;
   });
   window.setTimeout(function() {
     if (!fired)
       cr.dispatchSimpleEvent(el, 'webkitTransitionEnd');
   }, timeOut);
 }
+
+/**
+ * Alias for document.scrollTop getter.
+ * @param {Node} doc The document node where information will be queried from.

[Dan Beam, 2013/11/11 19:44:04]

all of these should be @param {!HTMLDocument}

+ * @return {value} The Y document scroll offset.

[Dan Beam, 2013/11/11 19:44:04]

and all of these, @return {number}

+ */
+function scrollTopForDocument(doc)
+{
+    return doc.documentElement.scrollTop || doc.body.scrollTop;
+}

[Dan Beam, 2013/11/11 19:44:04]

please match chrome-style not blink (2\s indent, brace on end of line).  for
example, the rest of this file's contents.

+
+/**
+ * Alias for document.scrollTop setter.
+ * @param {Node} doc The document node where information will be queried from.
+ * @param {value} value The Y target scroll offset.
+ */
+function setScrollTopForDocument(doc, value)
+{
+    doc.documentElement.scrollTop = doc.body.scrollTop = value;
+}
+
+/**
+ * Alias for document.scrollLeft getter.
+ * @param {Node} doc The document node where information will be queried from.
+ * @return {value} The X document scroll offset.
+ */
+function scrollLeftForDocument(doc)
+{
+    return doc.documentElement.scrollLeft || doc.body.scrollLeft;
+}
+
+/**
+ * Alias for document.scrollLeft setter.
+ * @param {Node} doc The document node where information will be queried from.
+ * @param {value} value The target X scroll offset.
+ */
+function setScrollLeftForDocument(doc, value)
+{

[Dan Beam, 2013/11/11 19:44:04]

is there any reason why we shouldn't simply be checking document.compatMode and
setting the scrollLeft/scrollTop values based on the return value (e.g.
'BackCompat' or 'CSS1Compat')?

+    doc.documentElement.scrollLeft = doc.body.scrollLeft = value;
+}