Roll libaddressinput deps to 51f4354

Roll libaddressinput deps to 51f4354

Updates to address formats and sub-region names.

BUG=NONE

Committed: https://crrev.com/2c3884ade2ff0606691a20e06a594c2004e9e84c
Cr-Commit-Position: refs/heads/master@{#302465}

[please use gerrit instead, 2014-10-29 17:02:13]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2014-10-29 17:02:14]

Evan: PTAL Patch Set 2.

[Evan Stade, 2014-10-29 21:33:16]

https://codereview.chromium.org/687213004/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/687213004/diff/40001/DEPS#newcode265
DEPS:265: Var('chromium_git') + '/external/libaddressinput.git' + '@' +
'51f43544159ce5e2d4e19dfa1673149ba73a0200',
Why are you rolling DEPS?

I'm concerned about new bugs this could introduce. For example, I remember there
was some behavior change planned for the android widget which would break our
usage.

[please use gerrit instead, 2014-10-29 21:45:09]

https://codereview.chromium.org/687213004/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/687213004/diff/40001/DEPS#newcode265
DEPS:265: Var('chromium_git') + '/external/libaddressinput.git' + '@' +
'51f43544159ce5e2d4e19dfa1673149ba73a0200',
On 2014/10/29 21:33:15, Evan Stade wrote:
> Why are you rolling DEPS?
> 
> I'm concerned about new bugs this could introduce. For example, I remember
there
> was some behavior change planned for the android widget which would break our
> usage.

I'm rolling DEPS to stay current with the upstream changes to address formats.
How can I check if the roll breaks our usage of the Android widget?

[Evan Stade, 2014-10-29 21:47:46]

On 2014/10/29 21:45:09, Rouslan Solomakhin wrote:
> https://codereview.chromium.org/687213004/diff/40001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/687213004/diff/40001/DEPS#newcode265
> DEPS:265: Var('chromium_git') + '/external/libaddressinput.git' + '@' +
> '51f43544159ce5e2d4e19dfa1673149ba73a0200',
> On 2014/10/29 21:33:15, Evan Stade wrote:
> > Why are you rolling DEPS?
> > 
> > I'm concerned about new bugs this could introduce. For example, I remember
> there
> > was some behavior change planned for the android widget which would break
our
> > usage.
> 
> I'm rolling DEPS to stay current with the upstream changes to address formats.
> How can I check if the roll breaks our usage of the Android widget?

by trying to use the android widget in android settings

[please use gerrit instead, 2014-10-29 23:51:50]

Indeed the widget has unusual padding after bumping the version. Fixing that
will require some time. I will table this patch until I have more time to look
into it.

[please use gerrit instead, 2014-10-30 00:13:16]

Nevermind, the weird padding is present in the beta channel too. That would have
to be fixed separately. No issues other than that.

[Evan Stade, 2014-10-31 21:22:23]

k, thanks for checking. lgtm

[please use gerrit instead, 2014-11-03 18:38:15]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:39:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687213004/40001

[commit-bot: I haz the power, 2014-11-03 19:34:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-03 19:35:03]

Patchset 3 (id:??) landed as
https://crrev.com/2c3884ade2ff0606691a20e06a594c2004e9e84c
Cr-Commit-Position: refs/heads/master@{#302465}