tools/testing/dart/test_runner.dart - Issue 687213002: Retry flaky tests on Safari.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 687213002: Retry flaky tests on Safari. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add retry for safari. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 3eb76e35d335d11728d3a3e261c71040dd6f0482..982625b3e5eb6a4bcfbaa053198fea19539509d4 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -2605,8 +2605,10 @@ bool shouldRetryCommand(CommandOutput output) {

}

- // We currently rerun dartium tests, see issue 14074

- if (command is BrowserTestCommand && command.displayName == 'dartium') {

+ // We currently rerun dartium tests, see issue 14074.

+ // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.

+ if (command is BrowserTestCommand &&

+ (command.displayName == 'dartium' || command.browser == 'safari')) {

ricow1 2014/10/29 12:57:12 command.displayName?

return true;

}

« no previous file with comments | « tools/bots/compiler.py ('k') | no next file » | no next file with comments »