Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 687213002: Retry flaky tests on Safari. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/bots/compiler.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 2587 matching lines...) Expand 10 before | Expand all | Expand 10 after
2598 // "xvfb-run" issue 7564, try re-running the test. 2598 // "xvfb-run" issue 7564, try re-running the test.
2599 bool containsFailureMsg(String line) { 2599 bool containsFailureMsg(String line) {
2600 return line.contains(MESSAGE_CANNOT_OPEN_DISPLAY) || 2600 return line.contains(MESSAGE_CANNOT_OPEN_DISPLAY) ||
2601 line.contains(MESSAGE_FAILED_TO_RUN_COMMAND); 2601 line.contains(MESSAGE_FAILED_TO_RUN_COMMAND);
2602 } 2602 }
2603 if (stdout.any(containsFailureMsg) || stderr.any(containsFailureMsg)) { 2603 if (stdout.any(containsFailureMsg) || stderr.any(containsFailureMsg)) {
2604 return true; 2604 return true;
2605 } 2605 }
2606 } 2606 }
2607 2607
2608 // We currently rerun dartium tests, see issue 14074 2608 // We currently rerun dartium tests, see issue 14074.
2609 if (command is BrowserTestCommand && command.displayName == 'dartium') { 2609 // We rerun tests on Safari because 6.2 and 7.1 are flaky. Issue 21434.
2610 if (command is BrowserTestCommand &&
2611 (command.browser == 'dartium' || command.browser == 'safari')) {
2610 return true; 2612 return true;
2611 } 2613 }
2612 } 2614 }
2613 return false; 2615 return false;
2614 } 2616 }
2615 2617
2616 /* 2618 /*
2617 * [TestCaseCompleter] will listen for 2619 * [TestCaseCompleter] will listen for
2618 * NodeState.Processing -> NodeState.{Successful,Failed} state changes and 2620 * NodeState.Processing -> NodeState.{Successful,Failed} state changes and
2619 * will complete a TestCase if it is finished. 2621 * will complete a TestCase if it is finished.
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2901 } 2903 }
2902 } 2904 }
2903 2905
2904 void eventAllTestsDone() { 2906 void eventAllTestsDone() {
2905 for (var listener in _eventListener) { 2907 for (var listener in _eventListener) {
2906 listener.allDone(); 2908 listener.allDone();
2907 } 2909 }
2908 _allDone(); 2910 _allDone();
2909 } 2911 }
2910 } 2912 }
OLDNEW
« no previous file with comments | « tools/bots/compiler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698