content/renderer/notification_provider.h - Issue 687183004: Remove the OnError method from notification delegates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/notification_provider.h

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: + Mac's QuitWithAppsController Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_notification_controller.cc ('K') | « content/public/browser/desktop_notification_delegate.h ('k') | content/renderer/notification_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/notification_provider.h

diff --git a/content/renderer/notification_provider.h b/content/renderer/notification_provider.h

index 9015515d4b06d87a8b67f5069d60bcb7385bf014..7428e2f5da1a5329df3caf300a0130650c8a1928 100644

--- a/content/renderer/notification_provider.h

+++ b/content/renderer/notification_provider.h

@@ -46,7 +46,6 @@ class NotificationProvider : public RenderFrameObserver,

// IPC handlers.

void OnDisplay(int id);

- void OnError(int id);

void OnClose(int id, bool by_user);

void OnClick(int id);

void OnNavigate();