content/browser/frame_host/render_frame_host_impl.cc - Issue 687183004: Remove the OnError method from notification delegates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_notification_controller.cc ('K') | « chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc ('k') | content/common/desktop_notification_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index fe26cdc40f9e45ac04a22e342718528a6993a918..0aa15c9f39003161549bd6498c54f748bd8a4cdf 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -101,16 +101,6 @@ class DesktopNotificationDelegateImpl : public DesktopNotificationDelegate {

rfh->GetRoutingID(), notification_id_));

}

- void NotificationError() override {

- RenderFrameHost* rfh =

- RenderFrameHost::FromID(render_process_id_, render_frame_id_);

- if (!rfh)

- return;

- rfh->Send(new DesktopNotificationMsg_PostError(

- rfh->GetRoutingID(), notification_id_));

- }

void NotificationClosed(bool by_user) override {

RenderFrameHost* rfh =

RenderFrameHost::FromID(render_process_id_, render_frame_id_);