Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/local_discovery/privet_notifications.cc

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/local_discovery/privet_notifications.h" 5 #include "chrome/browser/local_discovery/privet_notifications.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 PrivetNotificationDelegate::~PrivetNotificationDelegate() { 366 PrivetNotificationDelegate::~PrivetNotificationDelegate() {
367 } 367 }
368 368
369 std::string PrivetNotificationDelegate::id() const { 369 std::string PrivetNotificationDelegate::id() const {
370 return kPrivetNotificationID; 370 return kPrivetNotificationID;
371 } 371 }
372 372
373 void PrivetNotificationDelegate::Display() { 373 void PrivetNotificationDelegate::Display() {
374 } 374 }
375 375
376 void PrivetNotificationDelegate::Error() {
377 LOG(ERROR) << "Error displaying privet notification";
378 }
379
380 void PrivetNotificationDelegate::Close(bool by_user) { 376 void PrivetNotificationDelegate::Close(bool by_user) {
381 } 377 }
382 378
383 void PrivetNotificationDelegate::Click() { 379 void PrivetNotificationDelegate::Click() {
384 } 380 }
385 381
386 void PrivetNotificationDelegate::ButtonClick(int button_index) { 382 void PrivetNotificationDelegate::ButtonClick(int button_index) {
387 if (button_index == 0) { 383 if (button_index == 0) {
388 ReportPrivetUmaEvent(PRIVET_NOTIFICATION_CLICKED); 384 ReportPrivetUmaEvent(PRIVET_NOTIFICATION_CLICKED);
389 OpenTab(GURL(kPrivetNotificationOriginUrl)); 385 OpenTab(GURL(kPrivetNotificationOriginUrl));
(...skipping 15 matching lines...) Expand all
405 401
406 void PrivetNotificationDelegate::DisableNotifications() { 402 void PrivetNotificationDelegate::DisableNotifications() {
407 Profile* profile_obj = Profile::FromBrowserContext(profile_); 403 Profile* profile_obj = Profile::FromBrowserContext(profile_);
408 404
409 profile_obj->GetPrefs()->SetBoolean( 405 profile_obj->GetPrefs()->SetBoolean(
410 prefs::kLocalDiscoveryNotificationsEnabled, 406 prefs::kLocalDiscoveryNotificationsEnabled,
411 false); 407 false);
412 } 408 }
413 409
414 } // namespace local_discovery 410 } // namespace local_discovery
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698