Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: components/dom_distiller/core/distiller.cc

Issue 687183003: add options to specify original domain(s) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/distiller.cc
diff --git a/components/dom_distiller/core/distiller.cc b/components/dom_distiller/core/distiller.cc
index b5bd95dab38ade55ca266fccb64b5ea1e5cb8fc2..c67390dcdf797decda9eb226f36470fe59e73328 100644
--- a/components/dom_distiller/core/distiller.cc
+++ b/components/dom_distiller/core/distiller.cc
@@ -37,7 +37,12 @@ DistillerFactoryImpl::DistillerFactoryImpl(
DistillerFactoryImpl::~DistillerFactoryImpl() {}
-scoped_ptr<Distiller> DistillerFactoryImpl::CreateDistiller() {
+scoped_ptr<Distiller> DistillerFactoryImpl::CreateDistillerForUrl(
+ const GURL& unused) {
+ // The |unused| GURL is not needed here or now; it'll be specified later for
cjhopman 2014/10/29 17:13:41 I don't think the comment is necessary. I'd just d
kuan 2014/10/29 17:26:53 Done.
+ // DistillerPage::DistillPage() via TaskTracker::StartDistiller(). It's only
+ // needed if different URLs require different DomDistillerOption's, like the
+ // standalone ContentExtractor.
scoped_ptr<DistillerImpl> distiller(new DistillerImpl(
*distiller_url_fetcher_factory_, dom_distiller_options_));
return distiller.Pass();

Powered by Google App Engine
This is Rietveld 408576698