add options to specify original domain(s)

add options to specify original domain(s)

- this is part of the implementation of scoring mechanism for next/prev page
  links; details are in http://codereview.chromium.org/661883003.

- add options to standalone content extractor to specify original domain if page
  being processed is a file://
  1) --original-domain pairs with --url
  2) --original-domains pairs with --urls, delimited by ';', 1st domain is for
     1st url, etc.  eval tool will invoke content extractor with this option.

- for --original-domains, different URLs require different DomDistillerOptions
  to be passed to GWT distiller as individual --original-domain:
  1) rename DistillerFactory::CreateDistiller() to CreateDistillerForUrl(GURL)
  2) impl new DistillerFactory class for content extractor to create different
     options for different url's, i.e. a specific original domain for each url.

BUG=425952
Committed: https://crrev.com/8240530c2f8395ab9a5d8b63d72247fe01ee8c87
Cr-Commit-Position: refs/heads/master@{#301959}

[kuan, 2014-10-29 12:42:38]

kuan@chromium.org changed reviewers:
+ cjhopman@chromium.org

[kuan, 2014-10-29 12:42:39]

fyi, this requires roll of gwt changes in
https://codereview.chromium.org/688443006/.

[cjhopman, 2014-10-29 17:13:41]

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distiller.cc (right):

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distiller.cc:42: // The |unused| GURL is not
needed here or now; it'll be specified later for
I don't think the comment is necessary. I'd just drop it.

Otherwise, maybe just

// This default implementation has the same behavior for all URLs.

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/sta...
File components/dom_distiller/standalone/content_extractor.cc (right):

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/sta...
components/dom_distiller/standalone/content_extractor.cc:105: // A
semi-colon-separated (i.e. ';') list of original domains corresponding to
Do space-separated instead (like --urls)

[kuan, 2014-10-29 17:26:53]

i've addressed all comments in patch set 2.  ptal.  thx.

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/cor...
File components/dom_distiller/core/distiller.cc (right):

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/cor...
components/dom_distiller/core/distiller.cc:42: // The |unused| GURL is not
needed here or now; it'll be specified later for
On 2014/10/29 17:13:41, cjhopman wrote:
> I don't think the comment is necessary. I'd just drop it.
> 
> Otherwise, maybe just
> 
> // This default implementation has the same behavior for all URLs.

Done.

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/sta...
File components/dom_distiller/standalone/content_extractor.cc (right):

https://codereview.chromium.org/687183003/diff/1/components/dom_distiller/sta...
components/dom_distiller/standalone/content_extractor.cc:105: // A
semi-colon-separated (i.e. ';') list of original domains corresponding to
On 2014/10/29 17:13:41, cjhopman wrote:
> Do space-separated instead (like --urls)

hm.. i changed to use ';' in case the domain can't be extracted from the url,
which would result in an empty string - see
https://critique.corp.google.com/#review/78763318 -> driver.go -> word
"schemeAndRest".  i don't want scorer to crash for any mistake.

[cjhopman, 2014-10-29 17:35:13]

lgtm

[kuan, 2014-10-29 21:16:29]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687183003/20001

[commit-bot: I haz the power, 2014-10-29 22:57:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-29 22:57:51]

Patchset 2 (id:??) landed as
https://crrev.com/8240530c2f8395ab9a5d8b63d72247fe01ee8c87
Cr-Commit-Position: refs/heads/master@{#301959}