Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 687173002: Fix build with disable_nacl=1 (Closed)

Created:
6 years, 1 month ago by elecro
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix build with disable_nacl=1 Make the isolate generation aware that the NaCl can be disabled and don't try to use those files if it is disabled. BUG=428264 R=maruel@chromium.org TEST=./build/gyp_chromium -Ddisable_nacl=1 && ninja -C out/Release Committed: https://crrev.com/4b8c1e64ccae3a73fbf454ac33cd0879bbbdfa01 Cr-Commit-Position: refs/heads/master@{#302257}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser_tests.isolate View 1 5 chunks +24 lines, -9 lines 0 comments Download
M chrome/chrome.isolate View 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
elecro
Please take a look.
6 years, 1 month ago (2014-10-29 10:32:08 UTC) #1
M-A Ruel
Thanks! Note that since there's no CI testing on this configuration, it's bound to fail ...
6 years, 1 month ago (2014-10-29 13:06:16 UTC) #2
elecro
https://codereview.chromium.org/687173002/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://codereview.chromium.org/687173002/diff/1/chrome/browser_tests.isolate#newcode96 chrome/browser_tests.isolate:96: '../third_party/bidichecker/', On 2014/10/29 13:06:16, M-A Ruel wrote: > That's ...
6 years, 1 month ago (2014-10-29 14:04:03 UTC) #3
elecro
On 2014/10/29 14:04:03, elecro wrote: > https://codereview.chromium.org/687173002/diff/1/chrome/browser_tests.isolate > File chrome/browser_tests.isolate (right): > > https://codereview.chromium.org/687173002/diff/1/chrome/browser_tests.isolate#newcode96 > ...
6 years, 1 month ago (2014-10-31 09:40:19 UTC) #4
M-A Ruel
lgtm
6 years, 1 month ago (2014-10-31 12:15:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687173002/20001
6 years, 1 month ago (2014-10-31 12:53:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 13:53:43 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 13:54:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b8c1e64ccae3a73fbf454ac33cd0879bbbdfa01
Cr-Commit-Position: refs/heads/master@{#302257}

Powered by Google App Engine
This is Rietveld 408576698