Issue 687163005: Revert "Allow POSIX callers to specify a new file's mode."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687163005: Revert "Allow POSIX callers to specify a new file's mode." (Closed)

Created:
6 years, 1 month ago by Mike Wittman

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, asanka, erikwright+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Allow POSIX callers to specify a new file's mode." This reverts commit 3457f738b0dc2dd7d67fa84148d72066db9e0519. Breaks FileUtilTest.WriteFileWithMode on Android. BUG=409416, 362887 Committed: https://chromium.googlesource.com/chromium/src/+/e0c8785ea110e0a91523caf09100745924670693

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -67 lines)			Patch
M	base/files/file_util.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	base/files/file_util_posix.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	base/files/file_util_unittest.cc	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	content/browser/download/base_file_posix.cc	View	1 chunk	+21 lines, -28 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/e0c8785ea110e0a91523caf09100745924670693 Cr-Commit-Position: refs/heads/master@{#301968}

6 years, 1 month ago (2014-10-29 23:06:07 UTC) #1

Mike Wittman

6 years, 1 month ago (2014-10-29 23:06:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e0c8785ea110e0a91523caf09100745924670693.