Cleanup unscheduled use count for controls of coupled nodes.

Cleanup unscheduled use count for controls of coupled nodes.

R=titzer@chromium.org, jarin@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24991

[titzer, 2014-10-29 16:53:38]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2014-10-29 16:53:39]

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:164: void
Scheduler::IncrementUnscheduledUseCount(Node* node, int idx, Node* from) {
index

[titzer, 2014-10-29 16:55:08]

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:165: if (GetPlacement(from) == kCoupled &&
IsControlInputIndex(from, idx)) {
What about a different predicate, IsControlInputToCoupled() that basically
combines the conditions?

[Michael Starzinger, 2014-10-29 17:10:03]

Addressed comments. PTAL.

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc
File src/compiler/scheduler.cc (right):

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:164: void
Scheduler::IncrementUnscheduledUseCount(Node* node, int idx, Node* from) {
On 2014/10/29 16:53:39, titzer wrote:
> index

Done. Nooooo, 81 characters, the worst torture. :)

https://codereview.chromium.org/687133003/diff/1/src/compiler/scheduler.cc#ne...
src/compiler/scheduler.cc:165: if (GetPlacement(from) == kCoupled &&
IsControlInputIndex(from, idx)) {
On 2014/10/29 16:55:07, titzer wrote:
> What about a different predicate, IsControlInputToCoupled() that basically
> combines the conditions?

Done. Called it IsCoupledControlEdge() as before.

[titzer, 2014-10-29 17:27:25]

lgtm

[Michael Starzinger, 2014-10-29 17:37:21]

Committed patchset #3 (id:40001) manually as 24991 (presubmit successful).