Issue 68713009: Removed a bunch of references to GetActiveEntry in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68713009: Removed a bunch of references to GetActiveEntry in chrome/browser/ui. (Closed)

Created:
7 years, 1 month ago by jww

Modified:
7 years, 1 month ago

Reviewers:
Charlie Reis, benwells, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed a bunch of references to GetActiveEntry in chrome/browser/ui. See also the LGTMs in https://codereview.chromium.org/66993003/. BUG=273710 TBR=creis@chromium.org,sky@chromium.org,benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236365

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -20 lines)			Patch
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	6 chunks	+15 lines, -16 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 1 month ago (2013-11-16 05:01:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/68713009/1

7 years, 1 month ago (2013-11-20 21:38:16 UTC) #5

jww

7 years ago (2013-12-17 02:44:38 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/116573007/ by jww@chromium.org.

The reason for reverting is: Led to  a URL bar error, issue 324208..

Expand Messages | Collapse Messages