Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 68713007: Revert 235128 "Remove GSC usage from ExynosVideoDecodeAccelerator." (Closed)

Created:
7 years, 1 month ago by dharani1
Modified:
7 years, 1 month ago
Reviewers:
sheu
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Revert 235128 "Remove GSC usage from ExynosVideoDecodeAccelerator." Reason: http://crbug.com/319952 > Remove GSC usage from ExynosVideoDecodeAccelerator. > > With support for compositing from GL_TEXTURE_EXTERNAL_OES image (and support > from the Exynos GL stack for creating those textures), the video decoder > does not have to perform an explicit YUV->RGB color conversion step. > > +27% throughput on birds0.h264 through vda_unittest. > > BUG=167417 > TEST=local build, run on CrOS snow, vda_unittest > TEST=local build, run on Android/clank > > Review URL: https://codereview.chromium.org/23526070 TBR=sheu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+830 lines, -274 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/gpu/media/exynos_video_decode_accelerator.h View 13 chunks +83 lines, -22 lines 0 comments Download
M content/common/gpu/media/exynos_video_decode_accelerator.cc View 44 chunks +704 lines, -181 lines 0 comments Download
M content/common/gpu/media/rendering_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 6 chunks +25 lines, -53 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dharani1
7 years, 1 month ago (2013-11-15 21:29:27 UTC) #1
dharani1
7 years, 1 month ago (2013-11-15 21:32:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235427.

Powered by Google App Engine
This is Rietveld 408576698