Fix a synchronous event bug in futureStream.

pkg/scheduled_test/lib/src/utils.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library utils;
 
 import 'dart:async';
 
 import 'package:stack_trace/stack_trace.dart';
 
@@ skipping 73 matching lines @@
 /// then close.
 ///
 /// If [broadcast] is true, a broadcast stream is returned. This assumes that
 /// the stream returned by [future] will be a broadcast stream as well.
 /// [broadcast] defaults to false.
 Stream futureStream(Future<Stream> future, {bool broadcast: false}) {
   var subscription;
   var controller;
 
   future = future.catchError((e, stackTrace) {
-    if (controller == null) return;
-    controller.addError(e, stackTrace);
-    controller.close();
+    // Since [controller] is synchronous, it's likely that emitting an error
+    // will cause it to be cancelled before we call close.
+    if (controller != null) controller.addError(e, stackTrace);
+    if (controller != null) controller.close();
     controller = null;
   });
 
   onListen() {
     future.then((stream) {
       if (controller == null) return;
       subscription = stream.listen(
           controller.add,
           onError: controller.addError,
           onDone: controller.close);
@@ skipping 124 matching lines @@
 }
 
 /// Returns a string representation of [trace] that has the core and test frames
 /// folded together.
 String terseTraceString(StackTrace trace) {
   return new Trace.from(trace).terse.foldFrames((frame) {
     return frame.package == 'scheduled_test' || frame.package == 'unittest' ||
         frame.isCore;
   }).toString().trim();
 }