Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 687073002: Fix fallback in Metadata Cache. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix fallback in Metadata Cache. According to comments, setting null to a property should cause a fallback to other metadata providers, however this didn't work. This patch instead of setting null doesn't set the property at all, and as a result, the next provider is queried. To avoid an endless refetching metadata if it's not available, the property value is set to null if no other providers are available. Also, to avoid an endless loop caused by observers, the observers are called after all providers are queried and the missing property values are set to null. Basically, endBatchUpdates() is called after all computing is done, so no refetching will be invoked by observers. TEST=Tested manually. BUG=428213 Committed: https://crrev.com/72f7e25054dcd112093cadaf8ff658e6fccebfdc Cr-Commit-Position: refs/heads/master@{#301809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 2 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 1 month ago (2014-10-29 03:07:54 UTC) #2
hirono
lgtm!
6 years, 1 month ago (2014-10-29 08:56:04 UTC) #3
mtomasz
Thx!
6 years, 1 month ago (2014-10-29 08:57:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/687073002/1
6 years, 1 month ago (2014-10-29 08:58:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 09:43:50 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 09:44:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72f7e25054dcd112093cadaf8ff658e6fccebfdc
Cr-Commit-Position: refs/heads/master@{#301809}

Powered by Google App Engine
This is Rietveld 408576698