Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 687033002: Adding an option for peers to negotiate the length of the QUIC (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_1028
Project:
chromium
Visibility:
Public.

Description

Adding an option for peers to negotiate the length of the QUIC connection ID sent to them. This is a functional no-op until Chrome starts sending this configuration option, at which point it can still be turned off via FLAGS_allow_truncated_connection_ids_for_quic Also fixing quic config to not have protected member variables while I'm in there, because it was irritating me. Allowing truncated QUIC connection IDs. Off by default. Merge internal change: 78462599 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -21 lines) Patch
M net/quic/crypto/crypto_protocol.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_config.h View 3 chunks +12 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 11 chunks +26 lines, -8 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +61 lines, -4 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 4 chunks +18 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 1 month ago (2014-10-29 00:03:17 UTC) #1
Ryan Hamilton
6 years, 1 month ago (2014-10-29 02:58:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698