Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 687003005: Introduce phantom weak handles in the API and use them internally for debug info (Closed)

Created:
6 years, 1 month ago by Erik Corry Chromium.org
Modified:
6 years, 1 month ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Introduce phantom weak handles in the API and use them internally for debug info R=ulan@chromium.org, jochen@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25083

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -69 lines) Patch
M include/v8.h View 4 chunks +38 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug.cc View 9 chunks +24 lines, -21 lines 0 comments Download
M src/global-handles.h View 1 chunk +16 lines, -7 lines 0 comments Download
M src/global-handles.cc View 8 chunks +55 lines, -19 lines 1 comment Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +96 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Erik Corry
https://codereview.chromium.org/687003005/diff/1/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/687003005/diff/1/src/global-handles.cc#newcode268 src/global-handles.cc:268: Handle<Object> handle(*object, isolate); This CL is a reland of ...
6 years, 1 month ago (2014-11-02 18:41:45 UTC) #2
ulan
lgtm
6 years, 1 month ago (2014-11-03 14:18:44 UTC) #4
Erik Corry Chromium.org
6 years, 1 month ago (2014-11-03 17:27:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698