Issue 687003002: Remove PageOverlays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 687003002: Remove PageOverlays. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove PageOverlays. These were related to the inspector overlays, if we want to do this in the future we should place mojo::Views over the page in the sky debugger so sky itself doesn't need to manage the overlay views. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c0ada971995e8182dd707c6f9ac295a54caf41b0

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -564 lines)			Patch
D	sky/engine/public/web/WebPageOverlay.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	sky/engine/public/web/WebView.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	sky/engine/web/BUILD.gn	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	sky/engine/web/PageOverlay.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	sky/engine/web/PageOverlay.cpp	View	1 chunk	+0 lines, -159 lines	0 comments	Download
D	sky/engine/web/PageOverlayList.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	sky/engine/web/PageOverlayList.cpp	View	1 chunk	+0 lines, -139 lines	0 comments	Download
M	sky/engine/web/PageWidgetDelegate.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/web/PageWidgetDelegate.cpp	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	6 chunks	+3 lines, -22 lines	0 comments	Download
M	sky/engine/web/painting/ContinuousPainter.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sky/engine/web/painting/ContinuousPainter.cpp	View	1 chunk	+4 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

esprehn

6 years, 1 month ago (2014-10-28 22:44:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c0ada971995e8182dd707c6f9ac295a54caf41b0 (presubmit successful).