Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 686993003: [unpacker] Install the new zip unpacker extension by default. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[unpacker] Install the new zip unpacker extension by default. The app will be installed as an external component, as we don't want it to be uninstalled by users. TEST=Tested manually that the extension gets downloaded on startup. BUG=427775 Committed: https://crrev.com/9d6e421c5ca4dce8d1cc5e81bfafc1d1db7d003e Cr-Commit-Position: refs/heads/master@{#302232}

Patch Set 1 #

Patch Set 2 : Updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M chrome/browser/extensions/external_component_loader.cc View 1 2 chunks +29 lines, -11 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
mtomasz
@rockot: PTAL. Thanks.
6 years, 1 month ago (2014-10-30 06:43:55 UTC) #2
mtomasz
On 2014/10/30 06:43:55, mtomasz wrote: > @rockot: PTAL. Thanks. @rockot: Ping. This is very urgent.
6 years, 1 month ago (2014-10-31 05:19:56 UTC) #3
Ken Rockot(use gerrit already)
lgtm, sorry for the delay
6 years, 1 month ago (2014-10-31 05:41:40 UTC) #4
Ken Rockot(use gerrit already)
On 2014/10/31 05:41:40, Ken Rockot wrote: > lgtm, sorry for the delay actually not lgtm ...
6 years, 1 month ago (2014-10-31 05:46:40 UTC) #5
mtomasz
On 2014/10/31 05:46:40, Ken Rockot wrote: > On 2014/10/31 05:41:40, Ken Rockot wrote: > > ...
6 years, 1 month ago (2014-10-31 05:47:46 UTC) #6
Ken Rockot(use gerrit already)
Ah, got it. Thanks for clarifying. lgtm
6 years, 1 month ago (2014-10-31 05:48:28 UTC) #7
Ken Rockot(use gerrit already)
On 2014/10/31 05:48:28, Ken Rockot wrote: > Ah, got it. Thanks for clarifying. lgtm Please ...
6 years, 1 month ago (2014-10-31 05:48:51 UTC) #8
mtomasz
On 2014/10/31 05:48:51, Ken Rockot wrote: > On 2014/10/31 05:48:28, Ken Rockot wrote: > > ...
6 years, 1 month ago (2014-10-31 05:50:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686993003/20001
6 years, 1 month ago (2014-10-31 05:51:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 06:33:02 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 06:33:40 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d6e421c5ca4dce8d1cc5e81bfafc1d1db7d003e
Cr-Commit-Position: refs/heads/master@{#302232}

Powered by Google App Engine
This is Rietveld 408576698