Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 686973002: Remove isUnclippedDescendant. (Closed)

Created:
6 years, 1 month ago by hartmanng
Modified:
6 years, 1 month ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-reviews-rendering, arv+blink, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, Inactive, jchaffraix+rendering
Project:
blink
Visibility:
Public.

Description

Remove isUnclippedDescendant. It's no longer used for anything except a single layout test. The test still has pixel results, and I believe the only reason it had been using isUnclippedDescendant in the first place was to show that it was functioning the same way as the legacy composited scrolling path in the same situation. (The layout test was added here: https://chromiumcodereview.appspot.com/22620002) This patch will need a layout test rebaseline, because the pixel tests will no longer have any text on them. BUG=420742 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184553

Patch Set 1 #

Patch Set 2 : re-add description #

Patch Set 3 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -96 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/nested-render-surfaces.html View 1 1 chunk +4 lines, -10 lines 0 comments Download
M LayoutTests/compositing/overflow/nested-render-surfaces-with-intervening-clip.html View 1 2 1 chunk +5 lines, -11 lines 0 comments Download
M LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation.html View 1 2 1 chunk +8 lines, -15 lines 0 comments Download
D LayoutTests/compositing/overflow/resources/nested-render-surfaces.js View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 3 chunks +0 lines, -14 lines 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
hartmanng
Ian, please take a look.
6 years, 1 month ago (2014-10-28 21:29:28 UTC) #2
Ian Vollick
On 2014/10/28 at 21:29:28, hartmanng wrote: > Ian, please take a look. lgtm - thank ...
6 years, 1 month ago (2014-10-28 21:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686973002/20001
6 years, 1 month ago (2014-10-28 21:44:15 UTC) #5
hartmanng
Oops, the related layout tests also used that script and will need rebaselining. Trying again.
6 years, 1 month ago (2014-10-28 23:48:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686973002/40001
6 years, 1 month ago (2014-10-28 23:49:29 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 00:50:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184553

Powered by Google App Engine
This is Rietveld 408576698