Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 686963002: Switching profiler instrumentations from ScopedProfile to ScopedTracker (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, nkostylev+watch_chromium.org, zea+watch_chromium.org, tzik, browser-components-watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benquan, grt+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, nhiroki, oshima+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, michaeln, mkwst+watchlist-passwords_chromium.org, tfarina, stevenjb+watch_chromium.org, kinuko+fileapi, Dane Wallinga, dyu1, estade+watch_chromium.org, mmenke, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switching profiler instrumentations from ScopedProfile to ScopedTracker. This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process. This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel. BUG=401560 Committed: https://crrev.com/09e7ebe02c71d923e4655a0ad5e151b97344f091 Cr-Commit-Position: refs/heads/master@{#301950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -328 lines) Patch
M base/files/file_path_watcher_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M base/process/kill_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M base/synchronization/waitable_event_watcher_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/local_file_reader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_url_request_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autocomplete_history_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/captive_portal/captive_portal_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/invalidation/gcm_network_channel.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/search_engines/template_url_service.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/signin/core/browser/mutable_profile_oauth2_token_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/signin/core/browser/signin_account_id_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M components/translate/core/browser/translate_script.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/appcache/view_appcache_internals_job.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/histogram_internals_request_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tcmalloc_internals_request_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/hid/hid_connection_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/account_tracker.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/identity_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/base/socket_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/file_stream_context.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/upload_file_element_reader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_io.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/dns/dns_config_service_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_cache_transaction.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_stream_parser.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/http/partial_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 11 chunks +21 lines, -21 lines 0 comments Download
M net/socket/stream_listen_socket.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/socket/tcp_client_socket.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/tcp_socket_win.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/ssl/default_channel_id_store.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M net/udp/udp_socket_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_fetcher_response_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_data_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_simple_job.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M storage/browser/blob/local_file_stream_reader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/local_file_stream_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/http_bridge.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vadimt
brettw@ please provide OWNER's rubberstamp for everything. I'm pretty much sure that this array of ...
6 years, 1 month ago (2014-10-28 21:14:53 UTC) #2
brettw
lgtm
6 years, 1 month ago (2014-10-29 20:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686963002/1
6 years, 1 month ago (2014-10-29 20:55:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:10:53 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:11:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09e7ebe02c71d923e4655a0ad5e151b97344f091
Cr-Commit-Position: refs/heads/master@{#301950}

Powered by Google App Engine
This is Rietveld 408576698