Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: src/mksnapshot.cc

Issue 68693003: Have mercy and don't kill the Context::Scope immediately after birth. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 302
303 if (context.IsEmpty()) { 303 if (context.IsEmpty()) {
304 fprintf(stderr, 304 fprintf(stderr,
305 "\nException thrown while compiling natives - see above.\n\n"); 305 "\nException thrown while compiling natives - see above.\n\n");
306 exit(1); 306 exit(1);
307 } 307 }
308 if (i::FLAG_extra_code != NULL) { 308 if (i::FLAG_extra_code != NULL) {
309 // Capture 100 frames if anything happens. 309 // Capture 100 frames if anything happens.
310 V8::SetCaptureStackTraceForUncaughtExceptions(true, 100); 310 V8::SetCaptureStackTraceForUncaughtExceptions(true, 100);
311 HandleScope scope(isolate); 311 HandleScope scope(isolate);
312 v8::Context::Scope(v8::Local<v8::Context>::New(isolate, context)); 312 v8::Context::Scope cscope(v8::Local<v8::Context>::New(isolate, context));
313 const char* name = i::FLAG_extra_code; 313 const char* name = i::FLAG_extra_code;
314 FILE* file = i::OS::FOpen(name, "rb"); 314 FILE* file = i::OS::FOpen(name, "rb");
315 if (file == NULL) { 315 if (file == NULL) {
316 fprintf(stderr, "Failed to open '%s': errno %d\n", name, errno); 316 fprintf(stderr, "Failed to open '%s': errno %d\n", name, errno);
317 exit(1); 317 exit(1);
318 } 318 }
319 319
320 fseek(file, 0, SEEK_END); 320 fseek(file, 0, SEEK_END);
321 int size = ftell(file); 321 int size = ftell(file);
322 rewind(file); 322 rewind(file);
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 "", 394 "",
395 ser.CurrentAllocationAddress(i::NEW_SPACE), 395 ser.CurrentAllocationAddress(i::NEW_SPACE),
396 ser.CurrentAllocationAddress(i::OLD_POINTER_SPACE), 396 ser.CurrentAllocationAddress(i::OLD_POINTER_SPACE),
397 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE), 397 ser.CurrentAllocationAddress(i::OLD_DATA_SPACE),
398 ser.CurrentAllocationAddress(i::CODE_SPACE), 398 ser.CurrentAllocationAddress(i::CODE_SPACE),
399 ser.CurrentAllocationAddress(i::MAP_SPACE), 399 ser.CurrentAllocationAddress(i::MAP_SPACE),
400 ser.CurrentAllocationAddress(i::CELL_SPACE), 400 ser.CurrentAllocationAddress(i::CELL_SPACE),
401 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE)); 401 ser.CurrentAllocationAddress(i::PROPERTY_CELL_SPACE));
402 return 0; 402 return 0;
403 } 403 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698