 Chromium Code Reviews
 Chromium Code Reviews Issue 686913005:
  Turn off dump/emit routines when building minimal subzero.  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
    
  
    Issue 686913005:
  Turn off dump/emit routines when building minimal subzero.  (Closed) 
  Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master| Index: src/llvm2ice.cpp | 
| diff --git a/src/llvm2ice.cpp b/src/llvm2ice.cpp | 
| index 4dd24449766f6e873cd0148537ba182917f559cf..96933304d0064df7cc345adb535e60e0f436c44e 100644 | 
| --- a/src/llvm2ice.cpp | 
| +++ b/src/llvm2ice.cpp | 
| @@ -192,8 +192,7 @@ static int GetReturnValue(int Val) { | 
| static struct { | 
| const char *FlagName; | 
| int FlagValue; | 
| -} ConditionalBuildAttributes[] = {{"text_asm", ALLOW_TEXT_ASM}, | 
| - {"dump", ALLOW_DUMP}, | 
| +} ConditionalBuildAttributes[] = {{"dump", ALLOW_DUMP}, | 
| {"llvm_cl", ALLOW_LLVM_CL}, | 
| {"llvm_ir", ALLOW_LLVM_IR}, | 
| {"llvm_ir_as_input", ALLOW_LLVM_IR_AS_INPUT}, | 
| @@ -235,6 +234,11 @@ int main(int argc, char **argv) { | 
| if (DisableIRGeneration) | 
| DisableTranslation = true; | 
| + // Don't generate verbose messages if routines | 
| + // to dump messages are not available. | 
| + if (!ALLOW_DUMP) | 
| + VerboseList.clear(); | 
| + | 
| Ice::VerboseMask VMask = Ice::IceV_None; | 
| for (unsigned i = 0; i != VerboseList.size(); ++i) | 
| 
Jim Stichnoth
2014/11/12 14:34:15
Might be slightly cleaner to move the ALLOW_DUMP t
 
Karl
2014/11/17 18:59:46
Done.
 | 
| VMask |= VerboseList[i]; |