src/IceTranslator.cpp - Issue 686913005: Turn off dump/emit routines when building minimal subzero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTranslator.cpp

Issue 686913005: Turn off dump/emit routines when building minimal subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nits and format. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTranslator.cpp

diff --git a/src/IceTranslator.cpp b/src/IceTranslator.cpp

index edaa74f869dacb5b0c7a5b213098225b6d80c2ee..dd6917418a861a4984d4a366585124daf626314e 100644

--- a/src/IceTranslator.cpp

+++ b/src/IceTranslator.cpp

@@ -104,8 +104,8 @@ void Translator::lowerGlobals(

llvm::OwningPtr<TargetGlobalInitLowering> GlobalLowering(

TargetGlobalInitLowering::createLowering(Ctx->getTargetArch(), Ctx));

bool DisableTranslation = Ctx->getFlags().DisableTranslation;

- bool DumpGlobalVariables =

- Ctx->isVerbose() && Ctx->getFlags().VerboseFocusOn.empty();

+ const bool DumpGlobalVariables =

+ ALLOW_DUMP && Ctx->isVerbose() && Ctx->getFlags().VerboseFocusOn.empty();

Ostream &Stream = Ctx->getStrDump();

const IceString &TranslateOnly = Ctx->getFlags().TranslateOnly;

for (const Ice::VariableDeclaration *Global : VariableDeclarations) {

« no previous file with comments | « src/IceTimerTree.cpp ('k') | src/IceTypes.cpp » ('j') | src/IceTypes.cpp » ('J')