Fix insert/extract element vector operations to check index is literal

tests_lit/reader_tests/insertextract-err.ll

Index: tests_lit/reader_tests/insertextract-err.ll
diff --git a/tests_lit/reader_tests/insertextract-err.ll b/tests_lit/reader_tests/insertextract-err.ll
new file mode 100644
index 0000000000000000000000000000000000000000..dc524f6c162787bbd6bd34231994ddfe564e05ed
--- /dev/null
+++ b/tests_lit/reader_tests/insertextract-err.ll
@@ -0,0 +1,111 @@
+; Tests insertelement and extractelement vector instructions report
+; errors when malformed. Note: We can only test literal indexing since
+; llvm-as will not allow other bad forms of these instructions.
+
+; RUN: llvm-as < %s | pnacl-freeze \
+; RUN:   | not %llvm2ice -notranslate -build-on-read \
+; RUN:     -allow-pnacl-reader-error-recovery | FileCheck %s
+
+define void @ExtractV4xi1(<4 x i1> %v, i32 %i) {
+entry:
+  %e = extractelement <4 x i1> %v, i32 %i

[Jim Stichnoth, 2014/10/28 22:25:54]

For completeness, should you also test out-of-range constant indexes?

[Karl, 2014/10/29 17:00:58]

Done.

+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <4 x i1> %__0, i32 %__1
+  ret void
+}
+
+
+define void @ExtractV8xi1(<8 x i1> %v, i32 %i) {
+entry:
+  %e = extractelement <8 x i1> %v, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <8 x i1> %__0, i32 %__1
+  ret void
+}
+
+define void @ExtractV16xi1(<16 x i1> %v, i32 %i) {
+entry:
+  %e = extractelement <16 x i1> %v, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <16 x i1> %__0, i32 %__1
+  ret void
+}
+
+define void @ExtractV16xi8(<16 x i8> %v, i32 %i) {
+entry:
+  %e = extractelement <16 x i8> %v, i32 %i
+; CHECK-NEXT: Error: ({{.*}}) Vector index not integer constant: extractelement <16 x i8> %__0, i32 %__1
+  ret void
+}
+
+define void @ExtractV8xi16(<8 x i16> %v, i32 %i) {
+entry:
+  %e = extractelement <8 x i16> %v, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <8 x i16> %__0, i32 %__1
+  ret void
+}
+
+define i32 @ExtractV4xi32(<4 x i32> %v, i32 %i) {
+entry:
+  %e = extractelement <4 x i32> %v, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <4 x i32> %__0, i32 %__1
+  ret i32 %e
+}
+
+define float @ExtractV4xfloat(<4 x float> %v, i32 %i) {
+entry:
+  %e = extractelement <4 x float> %v, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: extractelement <4 x float> %__0, i32 %__1
+  ret float %e
+}
+
+define <4 x i1> @InsertV4xi1(<4 x i1> %v, i32 %pe, i32 %i) {
+entry:
+  %e = trunc i32 %pe to i1
+  %r = insertelement <4 x i1> %v, i1 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <4 x i1> %__0, i1 %__3, i32 %__2
+  ret <4 x i1> %r
+}
+
+define <8 x i1> @InsertV8xi1(<8 x i1> %v, i32 %pe, i32 %i) {
+entry:
+  %e = trunc i32 %pe to i1
+  %r = insertelement <8 x i1> %v, i1 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <8 x i1> %__0, i1 %__3, i32 %__2
+  ret <8 x i1> %r
+}
+
+define <16 x i1> @InsertV16xi1(<16 x i1> %v, i32 %pe, i32 %i) {
+entry:
+  %e = trunc i32 %pe to i1
+  %r = insertelement <16 x i1> %v, i1 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <16 x i1> %__0, i1 %__3, i32 %__2
+  ret <16 x i1> %r
+}
+
+define <16 x i8> @InsertV16xi8(<16 x i8> %v, i32 %pe, i32 %i) {
+entry:
+  %e = trunc i32 %pe to i8
+  %r = insertelement <16 x i8> %v, i8 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <16 x i8> %__0, i8 %__3, i32 %__2
+  ret <16 x i8> %r
+}
+
+define <8 x i16> @InsertV8xi16(<8 x i16> %v, i32 %pe, i32 %i) {
+entry:
+  %e = trunc i32 %pe to i16
+  %r = insertelement <8 x i16> %v, i16 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <8 x i16> %__0, i16 %__3, i32 %__2
+  ret <8 x i16> %r
+}
+
+define <4 x i32> @InsertV4xi32(<4 x i32> %v, i32 %e, i32 %i) {
+entry:
+  %r = insertelement <4 x i32> %v, i32 %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <4 x i32> %__0, i32 %__1, i32 %__2
+  ret <4 x i32> %r
+}
+
+define <4 x float> @InsertV4xfloat(<4 x float> %v, float %e, i32 %i) {
+entry:
+  %r = insertelement <4 x float> %v, float %e, i32 %i
+; CHECK: Error: ({{.*}}) Vector index not integer constant: insertelement <4 x float> %__0, float %__1, i32 %__2
+  ret <4 x float> %r
+}