Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 686903003: Remove RenderPart. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove RenderPart. This was part of the old plugin system, we don't need it. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4810d2f60e8748f8d0924d9e0dff95507ab1c8ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -243 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Frame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/rendering/RenderPart.h View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/core/rendering/RenderPart.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
M sky/engine/core/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 4 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 3 chunks +0 lines, -33 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.h View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/CompositingReasons.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/LinkHighlight.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm
6 years, 1 month ago (2014-10-28 21:48:11 UTC) #1
esprehn
6 years, 1 month ago (2014-10-28 22:01:31 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4810d2f60e8748f8d0924d9e0dff95507ab1c8ca.

Powered by Google App Engine
This is Rietveld 408576698