Remove obsolete ready and error events from MediaKeySession.

Remove obsolete ready and error events from MediaKeySession.

Also removes error() and keySystem() attributes as they are no longer needed.

BUG=418260
TEST=existing EME tests pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186808

[jrummell, 2014-10-29 01:13:07]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2014-10-29 01:13:07]

PTAL. Simply removing stuff not in the spec anymore. Local variable m_keySystem
still remains, as it is currently needed in generateRequest(). Could use
MediaKeys to get it, but we only have a WeakPtr<MediaKeys> so it may not be
around when needed.

[ddorwin, 2014-10-30 00:30:17]

The BUG for this is https://code.google.com/p/chromium/issues/detail?id=418260.
That one is currently "blocked on" the replacement. Should we remove that
dependency? We won't unflag without it, so that's probably fine. WDYT?

https://codereview.chromium.org/686893004/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/686893004/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:904: // FIXME: Remove this
event from the
Is Chrome still calling it? If no, NOTREACHED().

Rather than just deleting some code, why not actually remove the Chromium calls
then remove these from the interface in this CL?

[jrummell, 2014-10-30 21:32:28]

Updated to completely remove the events on the blink side. Includes a rebase
that affected the test file.

https://codereview.chromium.org/686893004/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/686893004/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:904: // FIXME: Remove this
event from the
On 2014/10/30 00:30:17, ddorwin wrote:
> Is Chrome still calling it? If no, NOTREACHED().
> 
> Rather than just deleting some code, why not actually remove the Chromium
calls
> then remove these from the interface in this CL?

Done.

[ddorwin, 2014-11-03 19:50:50]

LGTM, though please check if we need to remove event names.

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (left):

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:893: RefPtrWillBeRawPtr<Event>
event = Event::create(EventTypeNames::ready);
Did we add this event name? If so, we should remove it.

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:932: RefPtrWillBeRawPtr<Event>
event = Event::create(EventTypeNames::error);
ditto

[ddorwin, 2014-11-03 19:52:40]

Please also update the description to just be something like "Remove obsolete
ready and error events from MediaKeySession."

[jrummell, 2014-11-03 20:47:31]

jrummell@chromium.org changed reviewers:
+ dglazkov@chromium.org

[jrummell, 2014-11-03 20:47:32]

+dglazkov@ for OWNERS review of source/core, source/platform, and
public/platform. It is mostly removal of code, so should be easy to check.

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (left):

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:893: RefPtrWillBeRawPtr<Event>
event = Event::create(EventTypeNames::ready);
On 2014/11/03 19:50:50, ddorwin wrote:
> Did we add this event name? If so, we should remove it.

Done.

https://codereview.chromium.org/686893004/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:932: RefPtrWillBeRawPtr<Event>
event = Event::create(EventTypeNames::error);
On 2014/11/03 19:50:50, ddorwin wrote:
> ditto

error event used in a bunch of places (e.g. core/events/ErrorEvent.cpp).

[jrummell, 2014-11-10 19:47:18]

ping dglazkov@ for OWNERS review of source/core, source/platform, and
public/platform.

[jrummell, 2014-12-09 02:09:52]

another ping dglazkov@ for OWNERS review of source/core, source/platform, and
public/platform.

[philipj_slow, 2014-12-09 12:46:27]

LGTM for Source/core and Source/platform, I'll ask mkwst to do public/

[jrummell, 2014-12-09 18:57:02]

jrummell@chromium.org changed reviewers:
+ mkwst@chromium.org
- dglazkov@chromium.org

[jrummell, 2014-12-09 18:57:02]

+mkwst for OWNERS review of public/platform

[Mike West, 2014-12-09 19:05:56]

public/ LGTM.

[jrummell, 2014-12-09 19:47:00]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-12-09 19:47:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686893004/60001

[commit-bot: I haz the power, 2014-12-09 21:35:36]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186808