Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 686843002: Revert of harden pathops for pathological test (Closed)

Created:
6 years, 1 month ago by hcm
Modified:
6 years, 1 month ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of harden pathops for pathological test (patchset #19 id:410001 of https://codereview.chromium.org/633393002/) Reason for revert: Compile errors on bots Original issue's description: > These tests stress pathops by describing the union of circle-like paths that have tiny line segments embedded and double back to create near-coincident conditions. > > The fixes include > - detect when finding the active top loops between two possible answers > - preflight chasing winding to ensure answer is consistent > - binary search more often when quadratic intersection fails > - add more failure paths when an intersect is missed > > While this fixes the chrome bug, reenabling path ops in svg should be deferred until additional fixes are landed. > > TBR= > BUG=421132 > > Committed: https://skia.googlesource.com/skia/+/6f726addf3178b01949bb389ef83cf14a1d7b6b2 TBR=caryclark@google.com NOTREECHECKS=true NOTRY=true BUG=421132 Committed: https://skia.googlesource.com/skia/+/27c46a08a9210e9306b8ea1b00349ec198153c38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -3381 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkDCubicIntersection.cpp View 5 chunks +2 lines, -8 lines 0 comments Download
M src/pathops/SkDQuadIntersection.cpp View 8 chunks +4 lines, -66 lines 0 comments Download
M src/pathops/SkIntersections.h View 6 chunks +2 lines, -13 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M src/pathops/SkOpAngle.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M src/pathops/SkOpContour.h View 2 chunks +4 lines, -7 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.h View 7 chunks +14 lines, -28 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 39 chunks +108 lines, -484 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 8 chunks +8 lines, -57 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 3 chunks +4 lines, -53 lines 0 comments Download
M src/pathops/SkPathOpsPoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/pathops/SkReduceOrder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsBattles.cpp View 47 chunks +93 lines, -38 lines 0 comments Download
M tests/PathOpsDebug.cpp View 4 chunks +4 lines, -26 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 5 chunks +7 lines, -19 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 8 chunks +19 lines, -1746 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 4 chunks +8 lines, -30 lines 0 comments Download
M tests/PathOpsQuadReduceOrderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpTest.cpp View 8 chunks +16 lines, -13 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 chunk +167 lines, -732 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hcm
Created Revert of harden pathops for pathological test
6 years, 1 month ago (2014-10-28 17:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686843002/1
6 years, 1 month ago (2014-10-28 17:55:31 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 17:56:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 27c46a08a9210e9306b8ea1b00349ec198153c38

Powered by Google App Engine
This is Rietveld 408576698