Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 68683009: Rewrite include paths for Blink public/ headers that have moved (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
chromium-reviews, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, fischman+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rewrite include paths for Blink public/ headers that have moved This is a prerequisite for removing the old (redirected) headers. In a few DEPS and in webview_plugin.cc the include was redundant and just removed instead. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -61 lines) Patch
M chrome/browser/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/webview_plugin.h View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 3 chunks +1 line, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/gtk_window_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_sandbox_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/child/quota_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/cursor_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_info_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_info_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/texttrack_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webaudiosourceprovider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webaudiosourceprovider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webinbandtexttrack_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/websourcebuffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/resizing_mode_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/cursors/webcursor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/quota/quota_status_code.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-12 22:02:31 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-12 22:20:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68683009/1
7 years, 1 month ago (2013-11-12 22:34:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68683009/1
7 years, 1 month ago (2013-11-12 23:52:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35827
7 years, 1 month ago (2013-11-13 00:45:55 UTC) #5
philipj_slow
I also need an LGTM for content/common/view_messages.h from cevans or jln.
7 years, 1 month ago (2013-11-13 08:24:27 UTC) #6
jln (very slow on Chromium)
On 2013/11/13 08:24:27, philipj wrote: > I also need an LGTM for content/common/view_messages.h from cevans ...
7 years, 1 month ago (2013-11-13 22:03:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68683009/1
7 years, 1 month ago (2013-11-13 22:26:23 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-13 23:39:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/68683009/1
7 years, 1 month ago (2013-11-14 07:47:35 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 11:01:25 UTC) #11
Message was sent while issue was closed. 
Change committed as 235116

Powered by Google App Engine
This is Rietveld 408576698