Fixes the device/battery GN buildfile for ChromeOS.

Fixes the device/battery GN buildfile for ChromeOS.

is_linux contains chromeos, but chromeos already excludes
_default and _linux files above. This condition seems to
address the desktop linux instead.

BUG=428420
TEST=manually
R=timvolodine@chromium.org

Committed: https://crrev.com/37b3450122b4957c84b341e4cfd470b747107b8d
Cr-Commit-Position: refs/heads/master@{#301954}

[ppi, 2014-10-29 18:43:05]

fwiw, this lgtm. We'll still need an approval from Tim.

Thanks for the fix!

[timvolodine, 2014-10-29 18:49:49]

https://codereview.chromium.org/686773004/diff/1/device/battery/BUILD.gn
File device/battery/BUILD.gn (right):

https://codereview.chromium.org/686773004/diff/1/device/battery/BUILD.gn#newc...
device/battery/BUILD.gn:67: if (is_desktop_linux) {
what happens if it's a linux laptop? it should work there too.

[ppi, 2014-10-29 18:53:50]

A per build/config/BUILDCONFIG.gn,

  is_desktop_linux = is_linux && !is_chromeos

, so I think we've got that covered.

[ppi, 2014-10-29 18:53:51]

As per build/config/BUILDCONFIG.gn,

  is_desktop_linux = is_linux && !is_chromeos

, so I think we've got that covered.

[ppi, 2014-10-29 18:56:52]

Btw, I'd suggest making the CL title more descriptive, eg.

"Fixes the device/battery GN buildfile for ChromeOS."

[timvolodine, 2014-10-29 19:04:03]

On 2014/10/29 18:56:52, ppi wrote:
> Btw, I'd suggest making the CL title more descriptive, eg.
> 
> "Fixes the device/battery GN buildfile for ChromeOS."

ok in that case lgtm. the is_desktop_linux naming is a bit misleading though..
+1 for making the title as above

[Ben Chan, 2014-10-29 19:04:08]

On 2014/10/29 18:56:52, ppi wrote:
> Btw, I'd suggest making the CL title more descriptive, eg.
> 
> "Fixes the device/battery GN buildfile for ChromeOS."

thanks.  mukai, you can use BUG=428420

[Ben Chan, 2014-10-29 20:01:53]

On 2014/10/29 19:04:08, Ben Chan wrote:
> On 2014/10/29 18:56:52, ppi wrote:
> > Btw, I'd suggest making the CL title more descriptive, eg.
> > 
> > "Fixes the device/battery GN buildfile for ChromeOS."
> 
> thanks.  mukai, you can use BUG=428420

I verified this patch locally with GN. thanks

[Ben Chan, 2014-10-29 21:34:48]

The CQ bit was checked by benchan@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686773004/1

[commit-bot: I haz the power, 2014-10-29 22:45:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-29 22:46:30]

Patchset 1 (id:??) landed as
https://crrev.com/37b3450122b4957c84b341e4cfd470b747107b8d
Cr-Commit-Position: refs/heads/master@{#301954}