Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 686773002: Various cleanup/simplification in object-observe.js (Closed)

Created:
6 years, 1 month ago by adamk
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Various cleanup/simplification in object-observe.js The biggest change is the removal of the map wrapper objects: we now operate directly on the observation weak map, since there are already Get/GetOrCreate/Set functions for each info map. Various other small cleanups as well, including the deletion of unnecessary forwarding functions and making use of standard macros. R=arv@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -91 lines) Patch
M src/object-observe.js View 8 chunks +38 lines, -91 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
adamk
6 years, 1 month ago (2014-10-28 14:49:56 UTC) #2
arv (Not doing code reviews)
LGTM
6 years, 1 month ago (2014-10-28 17:53:04 UTC) #3
rossberg
lgtm
6 years, 1 month ago (2014-10-29 09:17:49 UTC) #4
adamk
6 years, 1 month ago (2014-10-29 10:32:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24972 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698