LayoutTests/http/tests/inspector/runtime/runtime-crafted-frame-execution-context.html - Issue 686763002: Fix Runtime.executionContextCreated for crafted iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/inspector/runtime/runtime-crafted-frame-execution-context.html

Issue 686763002: Fix Runtime.executionContextCreated for crafted iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Do not force context initialization Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/runtime/resources/blank.html ('k') | LayoutTests/http/tests/inspector/runtime/runtime-crafted-frame-execution-context-expected.txt » ('j') | Source/core/inspector/PageRuntimeAgent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../inspector-test.js"></script>	3 <script src="../inspector-test.js"></script>

4 <script src="../resources-test.js"></script>

5 <script src="resource-tree-test.js"></script>

6	4

7 <script>	5 <script>

8	6

9 function createCraftedIframe()	7 function createCraftedIframe()

10 {	8 {

11 var fabricatedFrame = document.createElement("iframe");	9 var fabricatedFrame = document.createElement("iframe");

12 fabricatedFrame.src = "#foo";	10 fabricatedFrame.src = "resources/blank.html";

13 document.body.appendChild(fabricatedFrame);	11 document.body.appendChild(fabricatedFrame);

14 fabricatedFrame.contentDocument.write("<div>bar</div>");	12 fabricatedFrame.contentDocument.write("<div>bar</div>");

15 }	13 }

16	14

17 function test()	15 function test()

18 {	16 {

19 InspectorTest.runAfterResourcesAreFinished(["inspector-test.js", "resources- test.js", "resource-tree-test.js"], step1);	17 function onExecutionCintextCreated(event)

20

21 function step1()

22 {	18 {

23 InspectorTest.addSniffer(WebInspector.resourceTreeModel, "_frameAttached ", InspectorTest.completeTest);	19 InspectorTest.addResult("ExecutionContextCreated: isMainWorldContext=" + event.data.isMainWorldContext);

24 InspectorTest.evaluateInPage("createCraftedIframe()");

25 }	20 }

	21 WebInspector.runtimeModel.addEventListener(WebInspector.RuntimeModel.Events. ExecutionContextCreated, onExecutionCintextCreated, {});
	yurys 2014/10/31 15:08:03 Can you turn this into a protocol test so that we Can you turn this into a protocol test so that we are sure that it works when no other agents are enabled? eustas 2014/11/03 20:14:16 Great idea. Updading protocol test I've found that Show quoted text On 2014/10/31 15:08:03, yurys wrote: > Can you turn this into a protocol test so that we are sure that it works when no > other agents are enabled? Great idea. Updading protocol test I've found that mainWorld for non-main frame shouldn't be reported when "windowCleared" notification arrives. Done.
	22 InspectorTest.evaluateInPage("createCraftedIframe()", InspectorTest.complete Test);

26 }	23 }

27	24

28 </script>	25 </script>

29	26

30 </head>	27 </head>

31 <body onload="runTest()">	28 <body onload="runTest()">

32 <p>Tests resource tree model on crafted iframe addition (will time out on failur e).</p>	29 <p>Tests resource tree model on crafted iframe addition (will time out on failur e).</p>

33 </body>	30 </body>

34 </html>	31 </html>

OLD	NEW