Issue 686743003: Fix incorrectly override virtual function name in VariableProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686743003: Fix incorrectly override virtual function name in VariableProxy (Closed)

Created:
6 years, 1 month ago by mvstanton

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix incorrectly override virtual function name in VariableProxy Add the OVERRIDE keyword to help catch such mistakes in future. R=svenpanne@chromium.org BUG=

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	src/ast.h	View		8 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Sven, A hilarious bug. I end up calling UNREACHABLE() when flag --vector-ics is on. ...

6 years, 1 month ago (2014-10-28 16:48:20 UTC) #1

Sven Panne

6 years, 1 month ago (2014-10-29 08:12:08 UTC) #2

Most of this CL is subsumed by https://codereview.chromium.org/688533002, so
please split off the "real" part.

Expand Messages | Collapse Messages