Issue 686723004: Make printing limbo lines in test_sky only print the prefix once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686723004: Make printing limbo lines in test_sky only print the prefix once. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Make printing limbo lines in test_sky only print the prefix once. This makes the output much more readable and you can actually see stacktraces. Long-term, we need to stick this output into the result of the previous test instead of having them be printed to stderr. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0ec2d5b6a71bfeb26af921da67c69f3123c0a9fb

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	sky/tools/webkitpy/layout_tests/port/driver.py	View		2 chunks	+10 lines, -4 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

6 years, 1 month ago (2014-10-29 02:44:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0ec2d5b6a71bfeb26af921da67c69f3123c0a9fb (presubmit successful).