Non-SFI mode: Implement nacl_irt_random only for nacl_helper_nonsfi.

src/nonsfi/irt/irt_interfaces.c

Index: src/nonsfi/irt/irt_interfaces.c
diff --git a/src/nonsfi/irt/irt_interfaces.c b/src/nonsfi/irt/irt_interfaces.c
index 562d204b71a58f26605fb3d5cbdf71cf0bf45646..aad81891a6b77d936218e40eccd48addcf977a9f 100644
--- a/src/nonsfi/irt/irt_interfaces.c
+++ b/src/nonsfi/irt/irt_interfaces.c
@@ -37,6 +37,7 @@
 #include "native_client/src/untrusted/irt/irt.h"
 #include "native_client/src/untrusted/irt/irt_dev.h"
 #include "native_client/src/untrusted/irt/irt_interfaces.h"
+#include "native_client/src/untrusted/nacl/nacl_random.h"
 
 /*
  * This is an implementation of NaCl's IRT interfaces that runs
@@ -431,6 +432,7 @@ static int futex_wake(volatile int *addr, int nwake, int *count) {
 }
 #endif
 
+

[Mark Seaborn, 2014/11/04 01:19:52]

Nit: don't add empty line here

[hidehiko, 2014/11/04 11:16:58]

Oops. Removed.

 #if defined(__linux__) || defined(__native_client__)
 static int irt_clock_getres(nacl_irt_clockid_t clk_id,
                             struct timespec *time_nacl) {
@@ -599,6 +601,10 @@ const struct nacl_irt_futex nacl_irt_futex = {
 };
 #endif
 
+const struct nacl_irt_random nacl_irt_random = {

[Mark Seaborn, 2014/11/04 01:19:52]

Please run the PNaCl toolchain trybots to check that this works there.

I suspect you need to update toolchain_build/pnacl_targetlibs.py to avoid
breaking the test for unsandboxed-PNaCl mode.

[hidehiko, 2014/11/04 11:16:59]

Good catch! Fixed.

+  nacl_secure_random,
+};
+
 #if defined(__linux__) || defined(__native_client__)
 const struct nacl_irt_clock nacl_irt_clock = {
   irt_clock_getres,
@@ -650,6 +656,7 @@ static const struct nacl_irt_interface irt_interfaces[] = {
   { NACL_IRT_TLS_v0_1, &nacl_irt_tls, sizeof(nacl_irt_tls), NULL },
   { NACL_IRT_THREAD_v0_1, &nacl_irt_thread, sizeof(nacl_irt_thread), NULL },
   { NACL_IRT_FUTEX_v0_1, &nacl_irt_futex, sizeof(nacl_irt_futex), NULL },
+  { NACL_IRT_RANDOM_v0_1, &nacl_irt_random, sizeof(nacl_irt_random), NULL },
 #if defined(__linux__) || defined(__native_client__)
   { NACL_IRT_CLOCK_v0_1, &nacl_irt_clock, sizeof(nacl_irt_clock), NULL },
 #endif