Chromium Code Reviews Chromium Code Reviews
Issue 686723003:
Non-SFI mode: Implement nacl_irt_random only for nacl_helper_nonsfi. (Closed)
Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client| OLD | NEW |
|---|---|
| 1 # -*- python -*- | 1 # -*- python -*- |
| 2 # Copyright (c) 2014 The Native Client Authors. All rights reserved. | 2 # Copyright (c) 2014 The Native Client Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 Import('env') | 6 Import('env') |
| 7 | 7 |
| 8 # This component implements NaCl IRT interfaces in terms of POSIX APIs. | 8 # This component implements NaCl IRT interfaces in terms of POSIX APIs. |
| 9 if not env.Bit('posix') and not env.Bit('nonsfi_nacl'): | 9 if not env.Bit('posix') and not env.Bit('nonsfi_nacl'): |
| 10 Return() | 10 Return() |
| 11 | 11 |
| 12 # Since we are only targeting Unix, not Windows/MSVC, we can use C99 | 12 # Since we are only targeting Unix, not Windows/MSVC, we can use C99 |
| 13 # language features. | 13 # language features. |
| 14 env.FilterOut(CFLAGS='-Wdeclaration-after-statement') | 14 env.FilterOut(CFLAGS='-Wdeclaration-after-statement') |
| 15 # Complaints about unused function arguments are too noisy. | 15 # Complaints about unused function arguments are too noisy. |
| 16 env.Append(CCFLAGS='-Wno-unused-parameter') | 16 env.Append(CCFLAGS='-Wno-unused-parameter') |
| 17 # TODO(mseaborn): We can enforce -Wstrict-prototypes after the uses of | 17 # TODO(mseaborn): We can enforce -Wstrict-prototypes after the uses of |
| 18 # DEFINE_STUB/USE_STUB are gone. | 18 # DEFINE_STUB/USE_STUB are gone. |
| 19 env.FilterOut(CFLAGS='-Wstrict-prototypes') | 19 env.FilterOut(CFLAGS='-Wstrict-prototypes') |
| 20 | 20 |
| 21 irt_query_list_o = env.ComponentObject( | 21 irt_query_list_o = env.ComponentObject( |
| 22 'irt_query_list', ['$MAIN_DIR/src/untrusted/irt/irt_query_list.c']) | 22 'irt_query_list', ['$MAIN_DIR/src/untrusted/irt/irt_query_list.c']) |
| 23 env.ComponentLibrary('irt_nonsfi', ['irt_interfaces.c', irt_query_list_o]) | 23 env.ComponentLibrary('irt_nonsfi', ['irt_interfaces.c', irt_query_list_o]) |
| 24 | |
| 25 # For testing purpose, we split irt_random from libirt_nonsfi.a, | |
|
Mark Seaborn
2014/11/04 01:19:52
Nit: "purpose" -> "purposes"
hidehiko
2014/11/04 11:16:58
Done.
| |
| 26 # which will be linked with the random_test. | |
|
Mark Seaborn
2014/11/04 01:19:52
Nit: "linked into random_test"?
hidehiko
2014/11/04 11:16:58
Done.
| |
| 27 env.ComponentLibrary('nacl_random_private', ['irt_random.c']) | |
| OLD | NEW |
