Source/core/css/resolver/StyleResolver.h - Issue 686723002: Improve RAII of StyleResolverState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.h

Issue 686723002: Improve RAII of StyleResolverState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: When baseRenderStyle!=0: 1) don't inherit, and 2) use defaultStyleForElement as fallback parent. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleResolver.h

diff --git a/Source/core/css/resolver/StyleResolver.h b/Source/core/css/resolver/StyleResolver.h

index 7470c15bf6e9599d1b85a5e009a06ae78072b174..ce226432a16b56c084ca52c2d70991c7caa15b42 100644

--- a/Source/core/css/resolver/StyleResolver.h

+++ b/Source/core/css/resolver/StyleResolver.h

@@ -50,6 +50,7 @@ class CSSValue;

class ContainerNode;

class Document;

class Element;

+class ElementResolveContext;

class ElementRuleCollector;

class Interpolation;

class MediaQueryEvaluator;

@@ -113,7 +114,6 @@ public:

PassRefPtr<RenderStyle> pseudoStyleForElement(Element*, const PseudoStyleRequest&, RenderStyle* parentStyle);

PassRefPtr<RenderStyle> styleForPage(int pageIndex);

- PassRefPtr<RenderStyle> defaultStyleForElement();

PassRefPtr<RenderStyle> styleForText(Text*);

static PassRefPtr<RenderStyle> styleForDocument(Document&);

@@ -260,7 +260,7 @@ private:

bool isFirstPage(int pageIndex) const;

String pageName(int pageIndex) const;

- bool pseudoStyleForElementInternal(Element&, const PseudoStyleRequest&, RenderStyle* parentStyle, StyleResolverState&);

+ bool pseudoStyleForElementInternal(const PseudoStyleRequest&, RenderStyle* parentStyle, StyleResolverState&);

Document& document() { return *m_document; }