Source/core/css/resolver/FontBuilder.h - Issue 686723002: Improve RAII of StyleResolverState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FontBuilder.h

Issue 686723002: Improve RAII of StyleResolverState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: When baseRenderStyle!=0: 1) don't inherit, and 2) use defaultStyleForElement as fallback parent. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/FontBuilder.h

diff --git a/Source/core/css/resolver/FontBuilder.h b/Source/core/css/resolver/FontBuilder.h

index 964c3ddae2d89393e849aadbcfbeb8ce226543dd..0f57b20db6e10bb87ebcac51f27c6ed0dc9b3cf8 100644

--- a/Source/core/css/resolver/FontBuilder.h

+++ b/Source/core/css/resolver/FontBuilder.h

@@ -41,9 +41,8 @@ class FontBuilder {

STACK_ALLOCATED();

WTF_MAKE_NONCOPYABLE(FontBuilder);

public:

- FontBuilder(const Document&);

+ FontBuilder(const Document&, RenderStyle*);

rune 2014/10/29 12:01:15 Seems like the FontBuilder construction change is

- void setStyle(RenderStyle* style) { m_style = style; }

void setInitial(float effectiveZoom);

void didChangeFontParameters(bool);