Source/core/css/CSSToLengthConversionData.h - Issue 686723002: Improve RAII of StyleResolverState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSToLengthConversionData.h

Issue 686723002: Improve RAII of StyleResolverState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: When baseRenderStyle!=0: 1) don't inherit, and 2) use defaultStyleForElement as fallback parent. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSToLengthConversionData.h

diff --git a/Source/core/css/CSSToLengthConversionData.h b/Source/core/css/CSSToLengthConversionData.h

index e9595dea95e20eb2f705e28638713fd05d90536f..4ffc3cbb4a81b2bd3dc2d7a1bd03827eba996fdf 100644

--- a/Source/core/css/CSSToLengthConversionData.h

+++ b/Source/core/css/CSSToLengthConversionData.h

@@ -56,9 +56,6 @@ public:

double viewportMinPercent() const;

double viewportMaxPercent() const;

- void setStyle(const RenderStyle* style) { m_style = style; }

- void setRootStyle(const RenderStyle* rootStyle) { m_rootStyle = rootStyle; }

rune 2014/10/29 12:15:21 These were used unused?

andersr 2014/10/29 13:29:46 setStyle was used in StyleResolverState::setStyle,

CSSToLengthConversionData copyWithAdjustedZoom(float newZoom) const

{

return CSSToLengthConversionData(m_style, m_rootStyle, m_viewportWidth, m_viewportHeight, newZoom, m_computingFontSize);