Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: Source/core/css/resolver/FontBuilderTest.cpp

Issue 686723002: Improve RAII of StyleResolverState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix assertions. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/FontBuilderTest.cpp
diff --git a/Source/core/css/resolver/FontBuilderTest.cpp b/Source/core/css/resolver/FontBuilderTest.cpp
index e272ebc3b7861e60811c6753d82de52576abe1fb..7aac1c47ff164f2381b1eaefeed844d2388f3694 100644
--- a/Source/core/css/resolver/FontBuilderTest.cpp
+++ b/Source/core/css/resolver/FontBuilderTest.cpp
@@ -4,6 +4,7 @@
#include "config.h"
#include "core/css/resolver/FontBuilder.h"
+#include "core/rendering/style/RenderStyle.h"
#include "core/testing/DummyPageHolder.h"
#include <gtest/gtest.h>
@@ -21,8 +22,9 @@ protected:
TEST_F(FontBuilderTest, StylePointerInitialisation)
{
OwnPtr<DummyPageHolder> dummy = DummyPageHolder::create(IntSize(800, 600));
- FontBuilder builder(dummy->document());
- EXPECT_EQ(0, getStyle(builder));
+ RefPtr<RenderStyle> style = RenderStyle::create();
+ FontBuilder builder(dummy->document(), style.get());
+ EXPECT_EQ(style.get(), getStyle(builder));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698