Source/core/css/resolver/FontBuilder.cpp - Issue 686723002: Improve RAII of StyleResolverState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FontBuilder.cpp

Issue 686723002: Improve RAII of StyleResolverState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix unused var + minor diff noise. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: Source/core/css/resolver/FontBuilder.cpp

diff --git a/Source/core/css/resolver/FontBuilder.cpp b/Source/core/css/resolver/FontBuilder.cpp

index a0cc60f30b974333e9b440d58ec892fdcb5ed2ae..2d91ad479bacad4c0565e259a7c86121e59e59cf 100644

--- a/Source/core/css/resolver/FontBuilder.cpp

+++ b/Source/core/css/resolver/FontBuilder.cpp

@@ -60,9 +60,9 @@ private:

FontDescription m_fontDescription;

};

-FontBuilder::FontBuilder(const Document& document)

+FontBuilder::FontBuilder(const Document& document, RenderStyle* style)

: m_document(document)

- , m_style(nullptr)

+ , m_style(style)

rune 2014/10/30 15:23:50 It looks like m_style should never be null. ASSERT

andersr 2014/10/31 13:02:15 Done.

, m_fontDirty(false)

{

ASSERT(document.frame());