Improve RAII of StyleResolverState.

Source/core/css/resolver/ElementResolveContext.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 18 matching lines @@
 
 class ContainerNode;
 class Document;
 class Element;
 class RenderStyle;
 
 // ElementResolveContext is immutable and serves as an input to the style resolve process.
 class ElementResolveContext {
     STACK_ALLOCATED();
 public:
-    explicit ElementResolveContext(const Document&);
-
-    explicit ElementResolveContext(Element&);
-
+    ElementResolveContext(Document&, Element*, RenderStyle* parentStyle);

[rune, 2014/10/29 13:02:14]

I liked it better when the construction for Document style was more explicit
without the Element parameter.

[andersr, 2014/10/29 13:29:47]

OK.

+    Document& document() const { return m_document; }
     Element* element() const { return m_element; }
     const ContainerNode* parentNode() const { return m_parentNode; }
+    RenderStyle* parentStyle() const { return m_parentStyle; }
+    ActiveAnimations* activeAnimations() const { return m_activeAnimations; }
+    const RenderStyle* baseRenderStyle() const { return m_baseRenderStyle; }
     const RenderStyle* rootElementStyle() const { return m_rootElementStyle; }
     EInsideLink elementLinkState() const { return m_elementLinkState; }
     bool distributedToInsertionPoint() const { return m_distributedToInsertionPoint; }
 
 private:
+    // In FontFaceSet and CanvasRenderingContext2D, we don't have an element to grab the document from.
+    // This is why we have to store the document separately.
+    Document& m_document;
     RawPtrWillBeMember<Element> m_element;
     RawPtrWillBeMember<ContainerNode> m_parentNode;
+    RenderStyle* m_parentStyle;
+    ActiveAnimations* m_activeAnimations;
+    const RenderStyle* m_baseRenderStyle;
     RenderStyle* m_rootElementStyle;
     EInsideLink m_elementLinkState;
     bool m_distributedToInsertionPoint;
 };
 
 } // namespace blink
 
 #endif // ElementResolveContext_h