Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 686693004: Fix extensions NSS/BoringSSL dependencies (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
scheib, Ryan Sleevi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix extensions NSS/BoringSSL dependencies The NSS dependency should be guarded by a use_openssl check. BoringSSL and NSS cannot be linked together as they define some of the same symbols. Update BUILD.gn analogously by depending on //crypto:platform. Also condition nss in build/all.gyp on use_openssl in preparation for https://codereview.chromium.org/694643002/ which will disable the nss and nspr targets altogether. BUG=429021 Committed: https://crrev.com/d1be6eac818a2f9b35973814c9ff1740fdca2863 Cr-Commit-Position: refs/heads/master@{#302325}

Patch Set 1 #

Patch Set 2 : excise it from all too #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 2 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +15 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-30 23:07:29 UTC) #2
davidben
+scheib for extensions OWNERS
6 years, 1 month ago (2014-10-30 23:21:49 UTC) #4
scheib
extensions* lgtm "Excise it from all.gyp too while I'm here" didn't make sense to me ...
6 years, 1 month ago (2014-10-31 00:49:18 UTC) #5
scheib
https://codereview.chromium.org/686693004/diff/40001/extensions/browser/BUILD.gn File extensions/browser/BUILD.gn (right): https://codereview.chromium.org/686693004/diff/40001/extensions/browser/BUILD.gn#newcode22 extensions/browser/BUILD.gn:22: "//crypto:platform", This doesn't seem to be addressed in patch ...
6 years, 1 month ago (2014-10-31 00:53:45 UTC) #6
davidben
Rephrased the description. How is it now? https://codereview.chromium.org/686693004/diff/40001/extensions/browser/BUILD.gn File extensions/browser/BUILD.gn (right): https://codereview.chromium.org/686693004/diff/40001/extensions/browser/BUILD.gn#newcode22 extensions/browser/BUILD.gn:22: "//crypto:platform", On ...
6 years, 1 month ago (2014-10-31 05:56:48 UTC) #7
scheib
lgtm again ;) Thanks for rewording the description!
6 years, 1 month ago (2014-10-31 19:30:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686693004/40001
6 years, 1 month ago (2014-10-31 20:09:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 21:00:17 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 21:00:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1be6eac818a2f9b35973814c9ff1740fdca2863
Cr-Commit-Position: refs/heads/master@{#302325}

Powered by Google App Engine
This is Rietveld 408576698