Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 686683005: Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (Closed)

Created:
6 years, 1 month ago by Mike Lerman
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). (patchset #1 id:1 of https://codereview.chromium.org/696283002/) Reason for revert: Common CL assumed to be causing Android Tests to fail: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16593 and http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23875 Original issue's description: > Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5). > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/382af4619960b659a5ac7952dcc04e20ebaf4fe4 > Cr-Commit-Position: refs/heads/master@{#302437} TBR=machenbach@chromium.org,v8-autoroll@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/56957b6e401489d556fe87e5ca77b1e36170314f Cr-Commit-Position: refs/heads/master@{#302458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike Lerman
Created Revert of Update V8 to version 3.30.29 (based on e634bdb290cb3761b9335d1bf7ec016fb3ebdbd5).
6 years, 1 month ago (2014-11-03 19:00:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686683005/1
6 years, 1 month ago (2014-11-03 19:01:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 19:03:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/56957b6e401489d556fe87e5ca77b1e36170314f Cr-Commit-Position: refs/heads/master@{#302458}
6 years, 1 month ago (2014-11-03 19:04:36 UTC) #4
Mike Lerman
6 years, 1 month ago (2014-11-03 19:17:33 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/680393004/ by mlerman@chromium.org.

The reason for reverting is: Undo the revert, it wasn't the cause of the test
failures..

Powered by Google App Engine
This is Rietveld 408576698